[FFmpeg-devel] [PATCH] huffyuvencdsp: Convert ff_diff_bytes_mmx to yasm

Timothy Gu timothygu99 at gmail.com
Wed Oct 21 03:27:08 CEST 2015


On Tue, Oct 20, 2015 at 2:18 PM James Almer <jamrial at gmail.com> wrote:

> Removing this will make the INLINE_MMXEXT if statement below fail to
> compile on
> builds with inline asm disabled (msvc, etc). Even with dead code
> elimination in
> mind you'd need at least a prototype for the relevant functions.
> Just move this line below to keep the INLINE_MMXEXT if statement wrapped
> with it.
>

Good catch!


> Fate passes, so aside from the above it LGTM.
>

Pushed, thanks for the review.

Timothy


More information about the ffmpeg-devel mailing list