[FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

Nicolas George george at nsup.org
Sat Oct 24 15:44:45 CEST 2015


Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
> Apologies for the copy/pasted patch, but can't send via send-email.

Maybe you should take some time to tackle your email troubles?

> ISO C %p format specifier applies to void * data pointers. This casts
> relevant pointers to void * in order to be strictly correct C.
> 
> Found by -Wpedantic on clang 3.7 (in particular -Wformat-pedantic).

I am rather against this change, it makes the code significantly less
readable, and this instance I see zero chances of it fixing an actual issue
any time.

There is a reason these warnings are called "pedantic": there are often
irrelevant.

Regards,

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list