[FFmpeg-devel] [PATCH 4/5] avfilter: avoid zero arguments to variadic macro

[Ganesh Ajjanagadde]

On Sat, Oct 24, 2015 at 10:16 AM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
> On Sat, Oct 24, 2015 at 9:52 AM, Nicolas George <george at nsup.org> wrote:
>> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
>>> Thanks for the super quick review. Will apply shortly. Do you (or
>>> others) think adding -Wgnu-zero-variadic-macro-arguments to configure
>>> is a good idea?
>>
>> Considering that each additional option takes ~15 ms in configure on a
>> fairly powerful box, not counting maintenance burden, I would say rather no.
>>
>> Let us enable by default warnings that detect common or sever mistakes,
>> extra warnings can be enabled manually once in a while to check for harmless
>> mistakes.
>
> ok, agreed. Someone (if they feel these things are useful) can set up
> a FATE client with them that sporadically runs, similar to the
> sanitizer builds. Of course, it can be done in an unsystematic way
> (like the way I did here) instead.

pushed

>
>>
>> Regards,
>>
>> --
>>   Nicolas George
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>