[FFmpeg-devel] [PATCH 03/11] avcodec/snowenc: use log2 instead of log() / log(2...)

[Ganesh Ajjanagadde]

On Thu, Oct 29, 2015 at 8:20 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Thu, Oct 29, 2015 at 12:20:01AM -0400, Ganesh Ajjanagadde wrote:
>> This is likely more precise and conveys the intent better.
>> The expression has also been accordingly simplified.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  libavcodec/snowenc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c
>> index 7e8269c..fb0cd3f 100644
>> --- a/libavcodec/snowenc.c
>> +++ b/libavcodec/snowenc.c
>> @@ -1547,7 +1547,7 @@ static void calculate_visual_weight(SnowContext *s, Plane *p){
>>                  }
>>              }
>>
>> -            b->qlog= (int)(log(352256.0/sqrt(error)) / log(pow(2.0, 1.0/QROOT))+0.5);
>> +            b->qlog= (int)(QROOT * log2(352256.0/sqrt(error)) + 0.5);
>
> LGTM
>
> thanks

pushed, thanks.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> While the State exists there can be no freedom; when there is freedom there
> will be no State. -- Vladimir Lenin
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>