[FFmpeg-devel] [PATCH v2] mpegts: demux BluRay text subtitles

[Michael Niedermayer]

On Tue, Sep 01, 2015 at 11:41:03AM +0000, Paul B Mahol wrote:
> On 9/1/15, Petri Hintukainen <phintuka at gmail.com> wrote:
> > On ti, 2015-09-01 at 09:06 +0000, Paul B Mahol wrote:
> >> On 9/1/15, Petri Hintukainen <phintuka at gmail.com> wrote:
> >> > ---
> >> >  libavcodec/avcodec.h    | 1 +
> >> >  libavcodec/codec_desc.c | 7 +++++++
> >> >  libavformat/mpegts.c    | 1 +
> >> >  3 files changed, 9 insertions(+)
> >> >
> >> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> >> > index 12a6b54..9d38b59 100644
> >> > --- a/libavcodec/avcodec.h
> >> > +++ b/libavcodec/avcodec.h
> >> > @@ -530,6 +530,7 @@ enum AVCodecID {
> >> >      AV_CODEC_ID_VPLAYER    = MKBETAG('V','P','l','r'),
> >> >      AV_CODEC_ID_PJS        = MKBETAG('P','h','J','S'),
> >> >      AV_CODEC_ID_ASS        = MKBETAG('A','S','S',' '),  ///< ASS as
> >> > defined
> >> > in Matroska
> >> > +    AV_CODEC_ID_HDMV_TEXT_SUBTITLE = MKBETAG('B','D','T','X'),
> >> >
> >> >      /* other specific kind of codecs (generally used for attachments)
> >> > */
> >> >      AV_CODEC_ID_FIRST_UNKNOWN = 0x18000,           ///< A dummy ID
> >> > pointing
> >> > at the start of various fake codecs.
> >> > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> >> > index c172bf8..487bc2f 100644
> >> > --- a/libavcodec/codec_desc.c
> >> > +++ b/libavcodec/codec_desc.c
> >> > @@ -2735,6 +2735,13 @@ static const AVCodecDescriptor
> >> > codec_descriptors[] =
> >> > {
> >> >          .long_name = NULL_IF_CONFIG_SMALL("WebVTT subtitle"),
> >> >          .props     = AV_CODEC_PROP_TEXT_SUB,
> >> >      },
> >> > +    {
> >> > +        .id        = AV_CODEC_ID_HDMV_TEXT_SUBTITLE,
> >>
> >> Why it must have _SUBTITLE ? Its kind of redundant.
> >
> > The other BluRay subtitle codec is AV_CODEC_ID_HDMV_PGS_SUBTITLE.
> 
> Ah, I did not know about that one, name is fine than.

patch applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150901/61b43b78/attachment.sig>