[FFmpeg-devel] [PATCH] avfilter/avf_showwaves: Check max_samples

Michael Niedermayer michaelni at gmx.at
Thu Sep 3 14:52:18 CEST 2015


From: Michael Niedermayer <michael at niedermayer.cc>

Fixes potential division by zero
Fixes: CID1292295

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavfilter/avf_showwaves.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
index 57a6b2e..a19acf5 100644
--- a/libavfilter/avf_showwaves.c
+++ b/libavfilter/avf_showwaves.c
@@ -203,6 +203,11 @@ static int push_single_pic(AVFilterLink *outlink)
     int col = 0;
     int64_t *sum = showwaves->sum;
 
+    if (max_samples == 0) {
+        av_log(ctx, AV_LOG_ERROR, "Too few samples\n");
+        return AVERROR(EINVAL);
+    }
+
     av_log(ctx, AV_LOG_DEBUG, "Create frame averaging %"PRId64" samples per column\n", max_samples);
 
     memset(sum, 0, nb_channels);
-- 
1.7.9.5



More information about the ffmpeg-devel mailing list