[FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

Agatha Hu ahu at nvidia.com
Fri Sep 11 07:29:06 CEST 2015


在 2015/9/10 17:48, Timo Rothenpieler 写道:
>> @@ -770,7 +780,7 @@ static av_cold int nvenc_encode_init(AVCodecContext
>> *avctx)
>>           avctx->qmin = -1;
>>           avctx->qmax = -1;
>>       } else if (ctx->cbr) {
>> -        if (!ctx->twopass) {
>> +        if (!ctx->twopass < 1) {
>
> This doesn't seem right at all, what is it supposed to do?
> Keep in mind that twopass is a tristate, with the default beeing -1,
> which means autoselect.
>

Sorry I made a mistake
+        if (!ctx->twopass < 1) {

It should be
+        if (ctx->twopass < 1) {
No wonder it doesn't seem right at all...

Agatha Hu



More information about the ffmpeg-devel mailing list