[FFmpeg-devel] [PATCH] avcodec: Switch bitrate to 64bit with the bump

[Carl Eugen Hoyos]

James Almer <jamrial <at> gmail.com> writes:

> On 9/14/2015 7:49 PM, Carl Eugen Hoyos wrote:
> > But nobody wants to send a patch with an updated 
> > commit message afaict.
> 
> How is that important?

Afaiu, it is the only objection that was raised.
(But I am not a native speaker and may of course 
have misunderstood and / or missed something)

> If you're talking about stating somewhere that
> we're dropping ABI compatibility then the 
> correct place is changelog, RELEASE_NOTES and/or 
> APIChanges

I don't think patches for any of those were sent 
but I may have missed them.

> not a random commit message.

I use git blame very often and don't find any 
commit message "random".

> This patch can go in as is, but it would be 
> preferable if you just drop the incompatible 
> abi check and simply make the fields 64bits.

I suggested this twice iirc and it was rejected 
so I wanted to produce some progress within a 
reasonable (?) timeframe since the version bump.

Thank you, Carl Eugen