[FFmpeg-devel] [PATCH] ffplay: fix silence insertion on error or pause

[Marton Balint]

On Mon, 4 Apr 2016, Michael Niedermayer wrote:

> On Sun, Apr 03, 2016 at 09:37:58PM +0200, Marton Balint wrote:
>> Insertion of silence was a bit broken since
>> df34b700981de606ca4847e1ed0bfdf9ac3e9104 because the info whether or not the
>> source buffer supposed to be silence must be kept between callbacks. Failing to
>> do so causes rogue samples from the last buffer to be presented, I guess even a
>> crash can occur under some circumstances.
>>
>> This patch uses a NULL audio_buf to keep the silence state across audio
>> callbacks.
>>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  ffplay.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> slightly off topic but
> does it sound better to repeat the last packet or to fill in
> silence for damaged packets ?
>

IMHO silence is better, especially when multiple damaged packets follow 
each other. But in the current version of ffplay it's not really relevant 
because we simply ignore the decoding errors, and error is only returned 
from audio_decode_frame in case of issues like ENOMEM.

Regards,
Marton