[FFmpeg-devel] [PATCH] Fix chroma height ratio for yuv410p

[Michael Niedermayer]

On Mon, Apr 18, 2016 at 09:49:40AM +0000, Isamu Mogi wrote:
> Chroma height for yuv410p is luma/2. Same as yuv440p and yuv420p.

no
but why was the first thought i had "wikipedia" and why was i correct
"4:1:0 This ratio is possible, and some codecs support it, but it is not widely used. This ratio uses half of the vertical ..."

do NOT ever use wikipedia for important decissions, its great to
look something up but its not accurate especially for things where
the correct awnser is unintuitv
also seems this one is known, check
https://en.wikipedia.org/wiki/Talk%3AChroma_subsampling about 4:1:0


[...]
> diff --git a/tests/ref/lavf/pixfmt b/tests/ref/lavf/pixfmt
> index ec75d4c..f0db104 100644
> --- a/tests/ref/lavf/pixfmt
> +++ b/tests/ref/lavf/pixfmt
> @@ -6,7 +6,7 @@ ac68f9fdd9d55efd0306d9b004038761 *./tests/data/pixfmt/yuv422p.yuv
>  304128 ./tests/data/pixfmt/yuv444p.yuv
>  ac68f9fdd9d55efd0306d9b004038761 *./tests/data/pixfmt/yuyv422.yuv
>  304128 ./tests/data/pixfmt/yuyv422.yuv
> -507c7e9f0c97660385df977469ca9e6d *./tests/data/pixfmt/yuv410p.yuv
> +f0d62d407a9bf98d25d8c0ae5493830f *./tests/data/pixfmt/yuv410p.yuv
>  304128 ./tests/data/pixfmt/yuv410p.yuv
>  8594ea0b8d7c2c964525b0801b5351de *./tests/data/pixfmt/yuv411p.yuv
>  304128 ./tests/data/pixfmt/yuv411p.yuv
> diff --git a/tests/ref/vsynth/vsynth1-svq1 b/tests/ref/vsynth/vsynth1-svq1
> index 9c1b6ff..d57dfb5 100644
> --- a/tests/ref/vsynth/vsynth1-svq1
> +++ b/tests/ref/vsynth/vsynth1-svq1
> @@ -1,4 +1,4 @@
> -a3206831d34197a2d236d82dd0248646 *tests/data/fate/vsynth1-svq1.mov
> -1334233 tests/data/fate/vsynth1-svq1.mov
> -9cc35c54b2c77d36bd7e308b393c1f81 *tests/data/fate/vsynth1-svq1.out.rawvideo
> -stddev:    9.58 PSNR: 28.50 MAXDIFF:  210 bytes:  7603200/  7603200
> +2396b396b25cffa0445d360977f5987a *tests/data/fate/vsynth1-svq1.mov
> +1295093 tests/data/fate/vsynth1-svq1.mov
> +cc95d739b3fb597f881d6c3a25f99f7d *tests/data/fate/vsynth1-svq1.out.rawvideo
> +stddev:   54.61 PSNR: 13.38 MAXDIFF:  249 bytes:  7603200/  7603200
             ^^^^^
this also shows that the change is wrong, the images dont match
anymore after it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160418/27aa8e1a/attachment.sig>