[FFmpeg-devel] [PATCH] avcodec/utils: do_decode: Assert that the decoder return value is not larger than the packet size

[wm4]

On Fri, 22 Apr 2016 05:14:30 +0200
Michael Niedermayer <michael at niedermayer.cc> wrote:

> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/utils.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index 52e0d92..b35fabc 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -2738,6 +2738,7 @@ static int do_decode(AVCodecContext *avctx, AVPacket *pkt)
>          avctx->internal->draining_done = 1;
>  
>      if (ret >= pkt->size) {
> +        av_assert0(ret == pkt->size);
>          av_packet_unref(avctx->internal->buffer_pkt);
>      } else {
>          int consumed = ret;

Basically all code using the "old" API expects that the decoder can
read beyond the buffer (making use of input padding I suppose). So I
think this is expected.