[FFmpeg-devel] [PATCH 13/13] lavc/videotoolboxenc: Set colorimetry values

[Richard Kern]

> On Apr 10, 2016, at 12:27 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> 
> Rick Kern <kernrj <at> gmail.com> writes:
> 
>> +enabled kCVImageBufferColorPrimaries_ITU_R_2020 && 
>> add_cppflags -DHAVE_VT_BT2020_KEYS
> 
> This is not ok, the define should be added to config.h.
> 
>> +#ifndef HAVE_VT_BT2020_KEYS
>> +# define kCVImageBufferColorPrimaries_ITU_R_2020   CFSTR("ITU_R_2020")
>> +# define kCVImageBufferTransferFunction_ITU_R_2020 CFSTR("ITU_R_2020")
>> +# define kCVImageBufferYCbCrMatrix_ITU_R_2020      CFSTR("ITU_R_2020")
>> +#endif
> 
> Is this safer than #ifndef kCVImageBufferYCbCrMatrix_ITU_R_2020?
These aren’t macros in the system header file.

> 
> Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel