[FFmpeg-devel] [PATCH] lavc/hevc_parse: Don't take a HEVCContext

[John Warburton]

Is it possible that this patch, particularly to libavcodec/hevc.h, is
causing my compilation error today, cross-compiling using mingw-w64
and gcc-5.3.0 from GNU/Linux to Windows 64-bit?

libavcodec/qsvenc_hevc.c: In function 'generate_fake_vps':
libavcodec/qsvenc_hevc.c:71:38: warning: passing argument 2 of
'ff_hevc_extract_rbsp' makes integer from pointer without a cast
[-Wint-conversion]
     ret = ff_hevc_extract_rbsp(NULL, avctx->extradata + 4,
avctx->extradata_size - 4, &sps_nal);
                                      ^
In file included from libavcodec/qsvenc_hevc.c:33:0:
libavcodec/hevc.h:1083:5: note: expected 'int' but argument is of type
'uint8_t * {aka unsigned char *}'
 int ff_hevc_extract_rbsp(const uint8_t *src, int length,
     ^
libavcodec/qsvenc_hevc.c:71:60: warning: passing argument 3 of
'ff_hevc_extract_rbsp' makes pointer from integer without a cast
[-Wint-conversion]
     ret = ff_hevc_extract_rbsp(NULL, avctx->extradata + 4,
avctx->extradata_size - 4, &sps_nal);
                                                            ^
In file included from libavcodec/qsvenc_hevc.c:33:0:
libavcodec/hevc.h:1083:5: note: expected 'HEVCNAL * {aka struct
HEVCNAL *}' but argument is of type 'int'
 int ff_hevc_extract_rbsp(const uint8_t *src, int length,
     ^
libavcodec/qsvenc_hevc.c:71:11: error: too many arguments to function
'ff_hevc_extract_rbsp'
     ret = ff_hevc_extract_rbsp(NULL, avctx->extradata + 4,
avctx->extradata_size - 4, &sps_nal);
           ^
In file included from libavcodec/qsvenc_hevc.c:33:0:
libavcodec/hevc.h:1083:5: note: declared here
 int ff_hevc_extract_rbsp(const uint8_t *src, int length,
     ^
common.mak:60: recipe for target 'libavcodec/qsvenc_hevc.o' failed
make: *** [libavcodec/qsvenc_hevc.o] Error 1
Build failure. Please see error messages above.

On Mon, Apr 25, 2016 at 5:27 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Mon, Apr 25, 2016 at 02:41:33PM +0100, Derek Buitenhuis wrote:
>>
>>  libavcodec/hevc.c        |  2 +-
>>  libavcodec/hevc.h        |  4 ++--
>>  libavcodec/hevc_parse.c  | 11 +++++------
>>  libavcodec/hevc_parser.c |  2 +-
>>  4 files changed, 9 insertions(+), 10 deletions(-)