[FFmpeg-devel] [PATCH] libavcodec/dnxhdenc: remove setting the codec_tag

[Paul B Mahol]

On 8/5/16, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Wed, Aug 03, 2016 at 02:31:04PM -0700, Mark Reid wrote:
>> setting the codec_tag no longer needed by movenc
>> it uses the dnxhr profile instead
>> ---
>>  libavcodec/dnxhdenc.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
>> index b0ee8a2..cbf4cd5 100644
>> --- a/libavcodec/dnxhdenc.c
>> +++ b/libavcodec/dnxhdenc.c
>> @@ -341,9 +341,6 @@ static av_cold int dnxhd_encode_init(AVCodecContext
>> *avctx)
>>      }
>>      av_log(avctx, AV_LOG_DEBUG, "cid %d\n", ctx->cid);
>>
>> -    if (ctx->cid >= 1270 && ctx->cid <= 1274)
>> -        avctx->codec_tag = MKTAG('A','V','d','h');
>
> does this not break older libavformat ?
> newer libavcodec could be used with older libavformat

Are you serious? That kind of scenario is bad idea and it never worked
and was never tested.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Asymptotically faster algorithms should always be preferred if you have
> asymptotical amounts of data
>