[FFmpeg-devel] [PATCH 2/2] avisynth: support pix_fmts added to AviSynth+

[Michael Niedermayer]

On Tue, Aug 16, 2016 at 12:57:53PM -0400, Stephen Hutchinson wrote:
> On 8/16/2016 9:31 AM, Michael Niedermayer wrote:
> >
> >breaks build
> >
> >libavformat/avisynth.c:100:40: error: ‘AVS_PLANAR_G’ undeclared here (not in a function)
> >libavformat/avisynth.c:100:54: error: ‘AVS_PLANAR_B’ undeclared here (not in a function)
> >libavformat/avisynth.c:101:43: error: ‘AVS_PLANAR_R’ undeclared here (not in a function)
> >libavformat/avisynth.c:103:57: error: ‘AVS_PLANAR_A’ undeclared here (not in a function)
> >libavformat/avisynth.c: In function ‘avisynth_read_packet_video’:
> >libavformat/avisynth.c:686:36: error: ‘AviSynthLibrary’ has no member named ‘avs_is_planar_rgb’
> >libavformat/avisynth.c:687:36: error: ‘AviSynthLibrary’ has no member named ‘avs_is_planar_rgba’
> >make: *** [libavformat/avisynth.o] Error 1
> >
> 
> That looks like the other patch updating
> compat/avisynth/avisynth_c.h wasn't applied first.

git log -2
commit 67f4e2cc041377cc5272a76ee1beaf73c3e49514
Author: Stephen Hutchinson <qyot27 at gmail.com>
Date:   Mon Aug 15 12:37:31 2016 -0400

    avisynth: support pix_fmts added to AviSynth+

    A number of new pix_fmts have been added to AviSynth+:
    16-bit packed RGB and RGBA
    10-, 12-, 14, and 16-bit YUV 4:2:0, 4:2:2, and 4:4:4
    8-, 10-, 12-, 14-, and 16-bit Planar RGB
    8-, 10-, 12-, 14-, and 16-bit Planar YUVA and Planar RGBA*
    10-, 12-, 14-, and 16-bit GRAY variants*
    32-bit floating point Planar YUV(A), Planar RGB(A), and GRAY*

    *some of which are not currently available pix_fmts here and were
     not added to the demuxer due to this

    Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

commit 220babe8078489065637b9b1bf2de013de7e6fd5
Author: Stephen Hutchinson <qyot27 at gmail.com>
Date:   Mon Aug 15 12:37:30 2016 -0400

    compat/avisynth: update AviSynth+ header

    Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

make distclean ; ./configure --enable-avisynth && make -j12

libavformat/avisynth.c:100:43: error: ‘AVS_PLANAR_G’ undeclared here (not in a function)
libavformat/avisynth.c:100:57: error: ‘AVS_PLANAR_B’ undeclared here (not in a function)
libavformat/avisynth.c:101:43: error: ‘AVS_PLANAR_R’ undeclared here (not in a function)
libavformat/avisynth.c:103:57: error: ‘AVS_PLANAR_A’ undeclared here (not in a function)
libavformat/avisynth.c: In function ‘avisynth_read_packet_video’:
libavformat/avisynth.c:686:36: error: ‘AviSynthLibrary’ has no member named ‘avs_is_planar_rgb’
libavformat/avisynth.c:687:36: error: ‘AviSynthLibrary’ has no member named ‘avs_is_planar_rgba’
make: *** [libavformat/avisynth.o] Error 1
make: *** Waiting for unfinished jobs....


This works before the 2 patches

That is all on linux, straight compilation no cross build or anything

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160816/8055c081/attachment.sig>