[FFmpeg-devel] [PATCH v11 01/11] avformat: Add fifo pseudo-muxer

Moritz Barsnick barsnick at gmx.net
Thu Aug 18 23:26:22 EEST 2016


On Thu, Aug 18, 2016 at 22:07:34 +0200, Jan Sebechlebsky wrote:
> > You're re-assigning ret in the error case but not using it. I think you
> > meant to return it?
> Yes, that's right - thanks for noticing that. I'll fix that and also the 
> issues above and resend the patch.

Apparently, the default compiler options (of some compilers?) don't
catch this?

Moritz

P.S.: There should be some developer guidelines with a set of extremely
strict warning/error options for all kinds of compilers, so developers
would check their code against them. No, I'm not ready to come forward
with a suggestion. ;)


More information about the ffmpeg-devel mailing list