[FFmpeg-devel] [PATCH] configure: force _WIN32_WINNT >= 0x0502 on mingw32 targets

[James Almer]

On 8/19/2016 6:13 PM, Hendrik Leppkes wrote:
> On Fri, Aug 19, 2016 at 10:24 PM, James Almer <jamrial at gmail.com> wrote:
>> On 8/19/2016 5:11 PM, Hendrik Leppkes wrote:
>>> On Fri, Aug 19, 2016 at 8:39 PM, James Almer <jamrial at gmail.com> wrote:
>>>> Windows versions earlier than XP are not supported.
>>>>
>>>> Should fix compilation of command line tools.
>>>>
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>> ---
>>>>  configure | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/configure b/configure
>>>> index 9b92426..2a2c06e 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -4919,6 +4919,8 @@ probe_libc(){
>>>>              (__MINGW32_MAJOR_VERSION == 3 && __MINGW32_MINOR_VERSION >= 15)" ||
>>>>              die "ERROR: MinGW32 runtime version must be >= 3.15."
>>>>          add_${pfx}cppflags -U__STRICT_ANSI__ -D__USE_MINGW_ANSI_STDIO=1
>>>> +        check_${pfx}cpp_condition _mingw.h "defined(_WIN32_WINNT) && _WIN32_WINNT >= 0x0502" ||
>>>> +            add_${pfx}cppflags -D_WIN32_WINNT=0x0502
>>>>          eval test \$${pfx_no_}cc_type = "gcc" &&
>>>>              add_${pfx}cppflags -D__printf__=__gnu_printf__
>>>>      elif check_${pfx}cpp_condition crtversion.h "defined _VC_CRT_MAJOR_VERSION"; then
>>>> --
>>>> 2.9.1
>>>
>>> Does that actually work? libav suggested such a patch, but they
>>> defined another variable to unlock new functions.
>>>
>>> - Hendrik
>>
>> I can't test, i don't have a mingw32 toolchain around. I know it
>> will add the extra define to the command line which in theory
>> should expose SetDllDirectory().
>>
>> What did they define? I can't find anything already in configure.
> 
> https://lists.libav.org/pipermail/libav-devel/2016-August/078670.html
> 
> No clue if its only for things that are CRT features or Windows
> features. can't test either.

According to https://msdn.microsoft.com/en-us/library/windows/desktop/ms686203(v=vs.85).aspx
_WIN32_WINNT == 0x0502 is enough to expose this function.

Michael, the FATE client seems to be yours. Could you test this patch?