[FFmpeg-devel] Patch libavformat/crypto to add seek when reading

[Michael Niedermayer]

On Tue, Aug 30, 2016 at 06:04:57PM +0100, Simon H wrote:
> hmm...  not sure i understand fate, even after a quick look.  Is there an
> explanation more complete than on the website?

the code and git log


> 
> I'm guessing that the ideal test for this would be to exercise the url
> functions directly from code; e.g.:

> 1. write some known data through crypto:, compare with pre-prepared output
> of openssl.

md5 is better than storing large reference data


> 2. read the same data linearly through crypto: , and check it's the same as
> it should be.
> 3. read the same data non-linearly through crypto: , and check it's the
> same as it should be.

yes


> 4. try to write some known data with seek, and expect failure?

maybe


> 
> Seems fate has some dedicated test programs; libavformat/tests/aes.c may be
> a good example to start with?
> Seems to just return 0 if OK, and 1 if fail?

a dedicated test would be possible, testing with ffmpeg -i crypto://
or similar might be easier though

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160830/14410d08/attachment.sig>