[FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

[Vittorio Giovara]

On Thu, Dec 1, 2016 at 2:22 PM, Nicolas George <george at nsup.org> wrote:
> Le primidi 11 frimaire, an CCXXV, Rostislav Pehlivanov a écrit :
>> Why do you insist on having a hole in the first place?
>
> Apparently, the values of the enum are used encode and decode
> standardized values in standardized formats like MPEG.
>
> I think this is a terrible design decision, and I would like to suggest
> to change it before it is too late.
>
> It will lead to all kinds of trouble if we want to support primaries
> from other standards with conflicting values, or if the standards
> introduce huge gaps in their allocated values.

Actually we already do, theora, vp8, vp9 and a few others have
completely different values for most color properties, and we just
check before initializing the context or frame fields. Since iso/itu
codecs are the ones that more consistently use all the properties
everywhere it makes sense that the enum values and field values match
and imho it's simpler to use.
-- 
Vittorio