[FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

[Nicolas George]

Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit :
> Which changes would those be?

The fix of errno / return value for pthread_cond_timedwait() for
example.

>	    This function is already set as nonblocking

I think you read this specific part of the code wrong. Unfortunately,
since this is a pivotal part of your reasoning, it ruins everything
else.

recv() can not be in non-blocking mode here because it would cause the
whole thread to behave in busy-wait, which is completely unacceptable.

Remember that pthread_cancel() was introduced here to eliminate polling.
Please do not bring it back. The way forward is to implement an event
loop for all protocols.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161202/ed648397/attachment.sig>