[FFmpeg-devel] [PATCH] lavf/matroskaenc.c: add early support for colour elements

James Almer jamrial at gmail.com
Mon Dec 5 04:47:11 EET 2016


On 11/4/2016 11:42 AM, Neil Birkbeck wrote:
> 
>     This seems to have been made official now, as usual under version 4
>     like every other new element.
>     https://github.com/Matroska-Org/libmatroska/commit/cd05bc14b42bd88218c61837208fa2b6c79b1de4 <https://github.com/Matroska-Org/libmatroska/commit/cd05bc14b42bd88218c61837208fa2b6c79b1de4>
> 
>     Could you confirm there were no changes to the draft and remove the
>     experimental checks for both decoder and encoder?
> 
> 
> There were no more changes to the draft that affected what was in this patch. However, from the muxer side, the last I checked there were still players that bailed out on any unknown elements (e.g., chrome, when playing back through media source extensions). And on the decoder, I've noticed an issue when the matroska_track_video_color is not specified: the defaults specified in the EbmlSyntax for this element were not propagated to the nested struct. Let me address that one first. 
> 

Just sent a patch solving this on the demuxer. Not the actual issue of
defaults not being propagated in general, but on this specific case with
the Colour master.

If you prefer trying to solve the core issue instead then that patch can
be dropped.



More information about the ffmpeg-devel mailing list