[FFmpeg-devel] [PATCH] Update for Chromaprint 1.4

[Hendrik Leppkes]

On Tue, Dec 6, 2016 at 3:02 PM, Georgi D. Sotirov <gdsotirov at dir.bg> wrote:
> Hello FFmpeg community,
>
> In new Chromaprint 1.4 (that was released 2016-12-03) type
> ChromaprintContext is no longer void *, but empty structure (see commit
> 2132e19 [1] from 2016-06-06 in BitBucket). This breaks compilation of
> libavformat/chromaprint.c, because member ctx of ChromaprintMuxContext
> should be pointer. This simple change resolves the problem.
>
> diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c
> index de73181..8c9a6c0 100644
> --- a/libavformat/chromaprint.c
> +++ b/libavformat/chromaprint.c
> @@ -39,11 +39,7 @@ typedef struct ChromaprintMuxContext {
>      int silence_threshold;
>      int algorithm;
>      FingerprintFormat fp_format;
> -#if CPR_VERSION_INT >= AV_VERSION_INT(1, 4, 0)
> -    ChromaprintContext * ctx;
> -#else
>      ChromaprintContext ctx;
> -#endif
>  } ChromaprintMuxContext;
>

Your patch looks odd, why are you removing 1.4 compat code?

- Hendrik