[FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

[Carl Eugen Hoyos]

2016-12-10 13:50 GMT+01:00 Mark Thompson <sw at jkqxz.net>:
> Fixes ticket #6003.
> ---
> On 10/12/16 12:09, Carl Eugen Hoyos wrote:
>> 2016-12-08 16:51 GMT+01:00 Mark Thompson <sw at jkqxz.net>:
>>> Fixes ticket #6003.
>>
>>>> May I suggest to revert this?
>>>>
>>>>> +    pp->bit_depth = h->h.bpp;
>>>>
>>>> Google doesn't easily find a version of va_dec_vp9.h
>>>> with _VADecPictureParameterBufferVP9->bit_depth.
>>>
>>> Urgh: libva 1.6.0 to 1.6.2 don't have this field.
>>>
>>> Hacky fix enclosing, only compile tested.
>>
>> As long as you work on a "better" fix, please either
>> apply or revert the original patch, build regressions
>> are not acceptable.
>
> Please review the two suggested fixes and hopefully express
> approval for one or other of them

No, no, no  - I mean: Not necessarily.

This is a build issue in a file that you maintain, you fix it
the way you like.

Carl Eugen