[FFmpeg-devel] [PATCH 5/7] avcodec/h263dec: Return the correct error code in explode mode

[wm4]

On Thu, 15 Dec 2016 21:21:11 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/h263dec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c
> index d0da1d31c1..75fc688e78 100644
> --- a/libavcodec/h263dec.c
> +++ b/libavcodec/h263dec.c
> @@ -713,7 +713,7 @@ frame_end:
>      }
>  
>      if (slice_ret < 0 && (avctx->err_recognition & AV_EF_EXPLODE))
> -        return ret;
> +        return slice_ret;
>      else
>          return get_consumed_bytes(s, buf_size);
>  }

Isn't there significant risk of running into endless loops with 0 bytes
decoded in patches like this? (Not sure if it can happen in this
specific case.) Seems quite questionable for a feature that will
probably be deprecated (truncated mode decoding).