[FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

[compn]

On Wed, 21 Dec 2016 12:51:18 -0600
Rodger Combs <rodger.combs at gmail.com> wrote:

> 
> > On Dec 21, 2016, at 02:27, Carl Eugen Hoyos <ceffmpeg at gmail.com>
> > wrote:
> > 
> > 2016-12-21 5:48 GMT+01:00 Rodger Combs <rodger.combs at gmail.com>:
> >> This allows us to report the correct codec ID here
> > 
> > Just curious: What does this fix?
> 
> Reporting in ffprobe, or when using lavf as a library. Some devices
> and decoders either refuse to decode MP2, or need to be told that the
> input is MP2 as opposed to MP3 ahead of time. This also means we'll
> write the correct ID when remuxing.

if mp2 is a problem, i would rather make it more difficult for the user
to encode mp2. by defaulting to mp3 and / or printing a warning message
about mp2. honestly i cant remember any good coming from someone using
mp2.

mp2 is dead, long live mp3.

also please share your mp2 sample, if you have not already done so, if
possible.

-compn