[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

[James Almer]

On 12/21/2016 10:49 PM, Michael Niedermayer wrote:
> On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote:
>> On 12/20/2016 11:36 PM, Michael Niedermayer wrote:
>>> On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote:
>>>> Signed-off-by: Thomas Turner <thomastdt at googlemail.com>
>>>> ---
>>>>  libavutil/Makefile           |   1 +
>>>>  libavutil/tests/audio_fifo.c | 196 +++++++++++++++++++++++++++++++++++++
>>>>  tests/fate/libavutil.mak     |   4 +
>>>>  tests/ref/fate/audio_fifo    | 228 +++++++++++++++++++++++++++++++++++++++++++
>>>>  4 files changed, 429 insertions(+)
>>>>  create mode 100644 libavutil/tests/audio_fifo.c
>>>>  create mode 100644 tests/ref/fate/audio_fifo
>>>
>>> applied
>>>
>>> thx
>>
>> This is crashing on some fate clients.
>>
>> I noticed it's using malloc and free instead of the av_malloc family,
>> so maybe it's related to that?
>> Patch attached in any case, it's proper even if not the reason behind
>> the crashes.
> 
> i saw the malloc/free before applying. It seemed to make sense to
> use libc functions in a test of our public API
> 
> why is it crashing ?

I don't know, i can't reproduce it. Seems to be OpenBSD FATE clients only
as far as i could see.