[FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add SIMD support for median prediction for planar formats

[Michael Niedermayer]

On Fri, Dec 23, 2016 at 05:44:22PM +0100, Paul B Mahol wrote:
> ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Fri Dec 23 15:41:51 2016 +0100| [ea93052db3594f93f2d10be085a770184da0513d] | committer: Paul B Mahol
> 
> avcodec/utvideodec: add SIMD support for median prediction for planar formats
> 
> ~10% faster overall.
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ea93052db3594f93f2d10be085a770184da0513d
> ---
> 
>  configure               |   2 +-
>  libavcodec/utvideo.h    |   2 +
>  libavcodec/utvideodec.c | 164 +++++++++++++++++++++++++++++++++++++++---------
>  libavcodec/utvideoenc.c |   3 +
>  4 files changed, 140 insertions(+), 31 deletions(-)

This breaks
> create a file with: (can be any ffmpeg version)
> ./ffmpeg -i matrixbench_mpeg2.mpg -an -vcodec utvideo -t 1 -pix_fmt yuv420p -pred median utv.avi
>
> if this is played with ffplay (with patch) it shows a brighter
> artifact on the left side of te screen

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161224/e76f9d0b/attachment.sig>