[FFmpeg-devel] [PATCH] x86: vc1dsp: Convert vc1_inv_trans_*_dc to NASM format

[Ronald S. Bultje]

Hi,

On Sun, Jan 31, 2016 at 6:27 PM, Timothy Gu <timothygu99 at gmail.com> wrote:

> On Sun, Jan 31, 2016 at 06:18:53PM -0300, James Almer wrote:
> > On 1/31/2016 4:48 PM, Timothy Gu wrote:
> > > ---
> > >  libavcodec/x86/vc1dsp.asm    | 104 ++++++++++++++++++++++
> > >  libavcodec/x86/vc1dsp_init.c |  13 +++
> > >  libavcodec/x86/vc1dsp_mmx.c  | 207
> -------------------------------------------
> > >  3 files changed, 117 insertions(+), 207 deletions(-)
> > >
> > > diff --git a/libavcodec/x86/vc1dsp.asm b/libavcodec/x86/vc1dsp.asm
> > > index 6415a83..f922927 100644
> > > --- a/libavcodec/x86/vc1dsp.asm
> > > +++ b/libavcodec/x86/vc1dsp.asm
> > > @@ -395,3 +395,107 @@ cglobal vc1_put_ver_16b_shift2, 4,7,0, dst, src,
> stride
> > >          jnz         .loop
> > >      REP_RET
> > >  %endif ; HAVE_MMX_INLINE
> > > +
> > > +%macro INV_TRANS_INIT 0
> > > +    movsxdifnidn linesizeq, linesized
> >
> > Maybe change the prototype so linesize is ptrdiff_t?
>
> I wanted to do that at first, but then I realized that to change this I'd
> need
> to change simple_idct and a bunch of other decoders.


Wait, what? How? Isn't this vc1-only code?

Ronald