[FFmpeg-devel] [PATCH] configure: remove the mixed declarations and code warning flag

Rostislav Pehlivanov atomnuker at gmail.com
Thu Feb 4 16:48:25 CET 2016


The only reason this existed was to allow for old compilers to not
complain/compile the project's code. As far as I know, we no longer have
support for such compilers hence this flag has become useless and we
have no reason to continue dragging so much behind the current standard
of the C language.

Michael Niedermayer has already expressed interest in removing said flag:
http://ffmpeg.org/pipermail/ffmpeg-devel/2016-January/187833.html

This will essentially help bring the project to near 21st century age
and finally allow for developers to save on line numbers by NOT having
to define the variable around which a for loop needs to iterate (e.g.
have for (int i = 0; i < N; i++) loops instead of having to define 'i'
at the start of the function like a normal variable), as well as more of
the syntactic sugar C99 permits.

Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index c415d5a..c8e59b5 100755
--- a/configure
+++ b/configure
@@ -5789,7 +5789,6 @@ disabled iconv || check_func_headers iconv.h iconv || check_lib2 iconv.h iconv -
 enabled debug && add_cflags -g"$debuglevel" && add_asflags -g"$debuglevel"
 
 # add some useful compiler flags if supported
-check_cflags -Wdeclaration-after-statement
 check_cflags -Wall
 check_cflags -Wdisabled-optimization
 check_cflags -Wpointer-arith
-- 
2.7.0



More information about the ffmpeg-devel mailing list