[FFmpeg-devel] [PATCH] avformat/mp3enc: Assert that the header we assembled is valid

[Michael Niedermayer]

On Fri, Feb 05, 2016 at 03:34:48PM +0100, Hendrik Leppkes wrote:
> On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
> <derek.buitenhuis at gmail.com> wrote:
> > On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
> >> because the code builds the header a few lines above, i assume
> >> the header we just build is correct
> >
> > Perhaps you could elaborate what CID1351343 is then, in the commit
> > messages.
> >
> 
> A Coverity ID, a false positive which we decide to "fix" with an
> assertion instead of marking it as such in the tool?

yes, i think its more robust if we assert that the header is valid
/the return code is ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160205/409bc274/attachment.sig>