[FFmpeg-devel] [PATCH] lavc/lavf: transmit stream_id information for mpegts KLV data packets

[Marton Balint]

On Sat, 13 Feb 2016, Stefano Sabatini wrote:

>> Subject: [PATCH] lavc/lavf: transmit stream_id information for mpegts KLV data
>>  packets
>>

[...]

> Someone else wants to have a look, or should I push as is?

I had a look at the mpegtsenc part as well:

> --- a/libavformat/mpegtsenc.c
> +++ b/libavformat/mpegtsenc.c

[...]

> @@ -1451,6 +1456,15 @@ static int mpegts_write_packet_internal(AVFormatContext *s, AVPacket *pkt)
>      const int64_t delay = av_rescale(s->max_delay, 90000, AV_TIME_BASE) * 2;
>      int64_t dts = pkt->dts, pts = pkt->pts;
>      int opus_samples = 0;
> +    int side_data_size;
> +    char *side_data = NULL;
> +    int stream_id = 0;

Why don't you use -1 as undefined? Theoretically stream_id can be zero 
as well, can't it?

Otherwise it is LGTM. I think you waited long enough, feel free to push.

Regards,
Marton