[FFmpeg-devel] Killing ASS timings in AVSubtitle ass text field

[Clément Bœsch]

On Sun, Feb 21, 2016 at 06:29:42PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 21, 2016 at 01:08:27PM +0100, Clément Bœsch wrote:
> > [PATCH 1/6] Kill timed SSA
> > 
> > This one is an old patch, which kills the usage of the old and unused
> > AV_CODEC_ID_SSA
> > 
> > [PATCH 2/6] lavc: allow subtitle text format to be ASS without timing
> > 
> > The big commit. Text based decoders do not have to rescale and insert the
> > timing in the ASS text anymore. A compatibility function
> > (convert_sub_to_old_ass_form()) is used to actually re-insert them. After this
> > commit, you can get clean AVSubtitle by setting sub_text_format=ass in decoder
> > context.
> > 
> > [PATCH 3/6] lavc/options: add ass_ro_flush_noop to flags2
> > 
> > Apparently, mpv do not want to reset the ReadOrder of the decoded subtitles on
> > flush. This addition of this option makes it possible.
> > 
> > [PATCH 4/6] ffmpeg: set sub_text_format to ass (without timing) by default
> > 
> > Make use of the newly introduced option. The nice side effect is that it fixes
> > all kind of long standing timing inaccuracy issues.
> > 
> > [PATCH 5/6] lavfi/ass: use ass_process_chunk() instead of ass_process_data()
> > 
> > libass has been willing to drop this since a long time...
> > 
> > [PATCH 6/6] lavc: deprecate decoded ass subtitles with timings
> > 
> > And the final deprecation to kill that code automatically at next major bump.
> > Compilation and FATE tested when set to 0.
> 
> libavcodec/ass_split.c: In function ‘ff_ass_split_dialog2’:
> libavcodec/ass_split.c:451:13: warning: passing argument 1 of ‘ff_ass_free_dialog’ from incompatible pointer type [enabled by default]

fixed locally, thx

(error code path, wasn't triggered so i didn't detect it when moving from
free(*) to free(**))

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160221/bc088f0e/attachment.sig>