[FFmpeg-devel] [PATCH 2/2] lavc: add h264 mediacodec decoder

[wm4]

On Mon, 22 Feb 2016 12:20:36 +0100
Matthieu Bouron <matthieu.bouron at gmail.com> wrote:

> From: Matthieu Bouron <matthieu.bouron at stupeflix.com>
> 
> ---
> ...

Some remarks:

- The qcom stuff should probably be moved into its own source file,
  because it's a lot of code, but self-contained.

- Do you really need h264_extradata_to_annexb_sps_pps? The BSF already
  creates mp4-style extradata, which MediaCodec apparently can take
  directly.

- There are several timeouts to avoid deadlocks in the dataflow,
  apparently. Is this inherently needed, or only because of the
  libavcodec API, which requires returning 0 or 1 output frames per
  input packet?

- The JNI code uses braces in case labels: "case (FF_JNI_FIELD): {"
  (Seems unusual coding style.)