[FFmpeg-devel] [PATCH 2/6] lavc: allow subtitle text format to be ASS without timing

[Clément Bœsch]

On Thu, Feb 25, 2016 at 02:10:15AM +0100, Michael Niedermayer wrote:
> On Wed, Feb 24, 2016 at 03:37:53PM +0100, Clément Bœsch wrote:
> > On Sun, Feb 21, 2016 at 06:34:43PM +0100, Michael Niedermayer wrote:
> > > On Sun, Feb 21, 2016 at 01:08:29PM +0100, Clément Bœsch wrote:
> > > [...]
> > > > diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h
> > > > index aa8bfac..b493dd1 100644
> > > > --- a/libavcodec/options_table.h
> > > > +++ b/libavcodec/options_table.h
> > > > @@ -519,6 +519,9 @@ static const AVOption avcodec_options[] = {
> > > >  {"do_nothing",  NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_SUB_CHARENC_MODE_DO_NOTHING},  INT_MIN, INT_MAX, S|D, "sub_charenc_mode"},
> > > >  {"auto",        NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_SUB_CHARENC_MODE_AUTOMATIC},   INT_MIN, INT_MAX, S|D, "sub_charenc_mode"},
> > > >  {"pre_decoder", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_SUB_CHARENC_MODE_PRE_DECODER}, INT_MIN, INT_MAX, S|D, "sub_charenc_mode"},
> > > > +{"sub_text_format", "set decoded text subtitle format", OFFSET(sub_text_format), AV_OPT_TYPE_INT, {.i64 = FF_SUB_TEXT_FMT_ASS_WITH_TIMINGS}, 0, 1, S|D, "sub_text_format"},
> > > > +{"ass",              NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_SUB_TEXT_FMT_ASS},              INT_MIN, INT_MAX, S|D, "sub_text_format"},
> > > > +{"ass_with_timings", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_SUB_TEXT_FMT_ASS_WITH_TIMINGS}, INT_MIN, INT_MAX, S|D, "sub_text_format"},
> > > >  {"refcounted_frames", NULL, OFFSET(refcounted_frames), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, A|V|D },
> > > 
> > > Missing docs update in doc/
> > > 
> > 
> > This is only for API users, so I'll add an entry in doc/APIChanges
> 
> they are shown in "./ffmpeg -h full"
> you can s/S|D/0/ to avoid that
> or some flag could be added that then prevents display
> 

The option can be used as debugging purpose, so it's actually OK to have
it listed, but it just serves no purpose for the common user.

Extensively documented in doc/APIChanges and pushed.

Thanks

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160226/11ce0f5b/attachment.sig>