[FFmpeg-devel] [PATCH] Ignore invalid sprop-parameter-sets missing PPS

[Andrew Shulgin]

Correct SPS and PPS are in the stream.
Maybe it's reasonale to use existing SPS. But i'm not sure how to implement
that.
Yeah really, setting extradata_size to 0 should not be skipped.

On Mon, Feb 29, 2016 at 1:01 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Sat, Feb 27, 2016 at 09:56:01PM +0200, Andrew Shulgin wrote:
> > Some Hikvison RTSP cameras send wrong sprop-parameter-sets in SDP - it's
> > missing PPS.
> >
> > Example of correct sprop-parameter-sets:
> > sprop-parameter-sets=Z0IAH5W4PASaEAAAcIAAFfkAQA==,aM48gA==
> > Example of wrong sprop-parameter-sets:
> > sprop-parameter-sets=Z0IAH5WoPASaEAAAcIAAFfkIQA==,
> >
> > My patch adds a workaround that ignores invalid sprop-parameter-sets.
>
> from where does it get the correct parameter set ?
> is it in the stream ? or repeated sprop-parameter-sets ?
>
> also shuldnt the sps be used instead of skipped?
> or the skip code be made conditional on codec->extradata_size > 0 ?
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Complexity theory is the science of finding the exact solution to an
> approximation. Benchmarking OTOH is finding an approximation of the exact
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>