[FFmpeg-devel] [PATCH v4 11/14] mips: do not disable any feature for generic cores

[Vicente Olivert Riera]

Dear Andreas Cadhalpun and Michael Niedermayer,

On 30/12/15 21:02, Andreas Cadhalpun wrote:
> On 30.12.2015 20:35, Michael Niedermayer wrote:
>> On Fri, Dec 04, 2015 at 03:48:27PM +0000, Vicente Olivert Riera wrote:
>>> We don't know which features are available when the user selects a
>>> generic core, so don't disable anything by default and let the user
>>> decide.
>>>
>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
>>> ---
>>> Changes v3 -> v4:
>>>   - Minor change in the commit log: remove "let's".
>>>
>>> Changes v2 -> v3:
>>>   - Change the logic of this patch. Instead of removing the generic core,
>>>     do not disable any feature and add a warning message to state that.
>>>     The patch subject has also changed accordingly.
>>>
>>> Changes v1 -> v2:
>>>   - Nothing.
>>>
>>>
>>>   configure | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 8bd47b9..2ee10db 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4159,8 +4159,8 @@ elif enabled mips; then
>>>               esac
>>>           ;;
>>>           generic)
>>> -            disable mips64r6
>>> -            disable msa
>>> +            # We do not disable anything. Is up to the user to disable
>>> +            # the unwanted features.
>>
>> i just noticed now but this breaks build
>
> That explains, why it got disabled here.
>
>> make distclean ; ./configure --cross-prefix=/usr/mips-linux-gnu/bin/ --cc='ccache mips-linux-gnu-gcc-4.4' --arch=mips --target-os=linux --enable-cross-compile && make -j12
>>
>> CC      libavcodec/mips/blockdsp_msa.o
>> In file included from ffmpeg/libavcodec/mips/blockdsp_msa.c:21:
>> ffmpeg/libavutil/mips/generic_macros_msa.h:25:17: warning: msa.h: No such file or directory
>
> This looks like configure should check for msa.h and disable msa
> if that header is not found.

yes, and it's better to reorder the remaining patches and apply the one 
who improves the detection of the ISAs, FPU and ASEs (DSP, MSA) first. I 
will re-send that 4-patch series.

Regards,

Vincent.

> Best regards,
> Andreas
>