[FFmpeg-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

[Piotr Bandurski]

Hi,

Great work, but I found some issues.

This I got with fuzzed file:

==13422== Invalid read of size 4
==13422==    at 0x834D003: cfhd_decode (cfhd.c:293)
==13422==    by 0x863D051: frame_worker_thread (pthread_frame.c:147)
==13422==    by 0x40ECF6F: start_thread (pthread_create.c:312)
==13422==    by 0x41EDBED: clone (clone.S:129)
==13422==  Address 0xe766ab4 is 104,852 bytes inside a block of size 153,600 free'd
==13422==    at 0x402B3D8: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==13422==    by 0x834CF4F: cfhd_decode (cfhd.c:532)
==13422==    by 0x863D051: frame_worker_thread (pthread_frame.c:147)
==13422==    by 0x40ECF6F: start_thread (pthread_create.c:312)
==13422==    by 0x41EDBED: clone (clone.S:129)
==13422== 

==13422== Invalid write of size 2
==13422==    at 0x834E0C3: cfhd_decode (cfhd.c:373)
==13422==    by 0x863D051: frame_worker_thread (pthread_frame.c:147)
==13422==    by 0x40ECF6F: start_thread (pthread_create.c:312)
==13422==    by 0x41EDBED: clone (clone.S:129)


http://www.datafilehost.com/d/89b4d321


and this with valid 4:4:4 file (not fuzzed):


*** Error in `ffmpeg_g': corrupted double-linked list: 0xaf025c80 ***
Aborted


http://www.datafilehost.com/d/1f726a3a



Here are all samples which I created to test your decoder (maybe will be useful for you):

http://www.datafilehost.com/d/90bbb71e


Regards