[FFmpeg-devel] [PATCH] ffplay: Add ignore_keydown and ignore_mousedown options.

[Ganesh Ajjanagadde]

On Thu, Jan 14, 2016 at 6:05 PM, Marton Balint <cus at passwd.hu> wrote:
>
> On Thu, 14 Jan 2016, Ganesh Ajjanagadde wrote:
>
>> On Thu, Jan 14, 2016 at 5:39 PM, Vittorio Gambaletta (VittGam)
>> <ffmpeg-dev at vittgam.net> wrote:
>
>
> [..]
>
>>>> I see no harm, but a new option should have a justification in the
>>>> commit message, i.e why do you want it, or what is your use case?
>>>
>>>
>>>
>>> I find seeking by clicking on the video window annoying, because I
>>> usually click on it to get focus on the window, and it seeks instead.
>>>
>>> ignorekeydown is the complement of ignoremousedown.
>>>
>>> Should I resend the patch with this comment?
>>
>>
>> Thanks for clarifying. Maybe best to wait for Marton's comments; he is
>> the maintainer.
>> Just to let you know, if this is accepted, doc/ffplay.texi will also
>> need an update.
>>
>
> I think it would make sense to change ffplay so that only the right mouse
> button would seek. This way we can avoid the issue. Anybody against this?

Kind of, it is slightly easier to tap the trackpad on my laptop than
to right click ;). But this may also be viewed as a negative, it is
quite easy to accidentally do it, and I have done that myself some
times.
In summary, can't think of a better idea myself, and I view it as a
cleaner solution than the proposed patch.

>
> Thanks,
> Marton
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel