[FFmpeg-devel] [PATCH 0/7] Replace native DCA decoder with libdcadec based one

[Andreas Cadhalpun]

On 14.01.2016 17:25, foo86 wrote:
> Full diff output has been omitted for deleted files. If git complains about
> applying the first patch, this can be also pulled from dca-replace branch at
> [1].

I'd prefer if you would post full patches here, i.e. including deleted files.

That aside, the new decoder seems fine from a security point of view, with
only some rare overflows in the dsp functions left.

However, this series breaks FATE.
The fate-dca-xll test should probably be disabled, as the reference was created
with the old, not bitexact decoder. (It currently fails due to the disable_xll
option being gone, but fixing that reveals the changed output.)

The checkasm test needs to be updated:
$ make fate-checkasm
CC	tests/checkasm/dcadsp.o
In file included from tests/checkasm/dcadsp.c:31:0:
tests/checkasm/dcadsp.c: In function ‘checkasm_check_dcadsp’:
tests/checkasm/dcadsp.c:85:21: error: ‘DCADSPContext {aka struct DCADSPContext}’ has no member named ‘lfe_fir’
     if (check_func(c.lfe_fir[0], "dca_lfe_fir0"))
                     ^
tests/checkasm/checkasm.h:71:75: note: in definition of macro ‘check_func’
 #define check_func(func, ...) (func_ref = checkasm_check_func((func_new = func), __VA_ARGS__))
                                                                           ^
tests/checkasm/dcadsp.c:88:21: error: ‘DCADSPContext {aka struct DCADSPContext}’ has no member named ‘lfe_fir’
     if (check_func(c.lfe_fir[1], "dca_lfe_fir1"))
                     ^
tests/checkasm/checkasm.h:71:75: note: in definition of macro ‘check_func’
 #define check_func(func, ...) (func_ref = checkasm_check_func((func_new = func), __VA_ARGS__))
                                                                           ^
common.mak:60: recipe for target 'tests/checkasm/dcadsp.o' failed
make: *** [tests/checkasm/dcadsp.o] Error 1

Best regards,
Andreas