[FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

Hendrik Leppkes h.leppkes at gmail.com
Fri Jan 15 09:17:23 CET 2016


On Thu, Jan 14, 2016 at 10:58 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> libavutil/pixfmt.h defines a collection of endian-specific pixel formats as
> macros. These macro names can cause conflicts with external projects that
> use those identifiers for their own purposes. Here's a patch to define
> these aliases as enumerators instead of macros, please consider merging:
>
>
> https://github.com/zygoloid/FFmpeg/commit/c20a0e2e66e52c45b9193bc750165b7ecf7f3ca4
>
> (Note that AV_PIX_FMT_Y400A was already defined as an enumerator in the
> PixelFormat enumeration, so I deleted its (no-op) macro entirely.)

In contrast to earlier times where this was not the case and rather
generic names were defined, all those macros are properly namespaced
AV_*, so any conflicts with other software can easily be avoided by
not using our namespace for their own names.
I don't see the point potentially breaking API compat for this.

- Hendrik


More information about the ffmpeg-devel mailing list