[FFmpeg-devel] [PATCH] lavu: add ff_pthread_setname() and use it in various places

[Clément Bœsch]

On Wed, Jan 20, 2016 at 07:29:02PM -0300, James Almer wrote:
[...]
> CC      libavformat/async.o
> F:/msys/ffmpeg/src/libavformat/async.c: In function 'async_buffer_task':
> F:/msys/ffmpeg/src/libavformat/async.c:184:5: error: implicit declaration of function 'ff_thread_setname' [-Werror=implicit-function-declaration]
>      ff_thread_setname("lavf-async-buf");
>      ^
> cc1.exe: some warnings being treated as errors
> /ffmpeg/src/common.mak:60: recipe for target 'libavformat/async.o' failed
> make: *** [libavformat/async.o] Error 1
> 
> You forgot w32threads and os2threads :P
> 

derp, added a define locally in this scope as well, thanks. New patch
attached.

> Quickest fix is to also define ff_thread_setname to (0) for those, like you're
> doing for the no threads builds.

> Proper fix IMO would be to do what i mentioned in my other reply to leave things
> ready in case someone wants to implement this function at a latter time.
> 

I don't really like the idea of writing a pthread_setname() function (if
this function becomes standard one day it's going to be named as such and
will break things)

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavu-add-ff_pthread_setname-and-use-it-in-various-pl.patch
Type: text/x-diff
Size: 4472 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160120/57b25066/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160120/57b25066/attachment.sig>