[FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

[James Almer]

On 1/24/2016 5:20 PM, Andreas Cadhalpun wrote:
> On 24.01.2016 21:14, Ronald S. Bultje wrote:
>> On Sun, Jan 24, 2016 at 3:10 PM, Andreas Cadhalpun <
>> andreas.cadhalpun at googlemail.com> wrote:
>>
>>> On 24.01.2016 20:54, Hendrik Leppkes wrote:
>>>> On Sun, Jan 24, 2016 at 8:51 PM, Andreas Cadhalpun
>>>> <andreas.cadhalpun at googlemail.com> wrote:
>>>>> On 24.01.2016 20:40, Hendrik Leppkes wrote:
>>>>>> Unfortunately that doesn't work when there is no common path, ie.
>>>>>> sources on another drive (say D:) as my build directory (say C:)
>>>>>
>>>>> Don't do that then?
>>>>
>>>> Thats not an answer.
>>>
>>> When the build environment has so many limitations some things just
>>> don't work.
>>
>>
>> This used to work.
>>
>> Fix it, or revert.
> 
> Who uses that way to build ffmpeg in an MSVC environment?

It doesn't matter. People could do it before this set of patches if they
wanted to and now they can't.

> 
> On 24.01.2016 21:15, Timothy Gu wrote:
>> It's not,
> 
> Exactly.
> 
>> but it used to work, and it doesn't work now.
> 
> And there is an easy workaround.

It is absolutely unacceptable to say "do something else" as a "workaround"
to a breakage introduced by a new feature.

Unless you can fix this for every usecase that was working before this
in the very short term, as several people told you already these patches
*must* be reverted until a proper fix is found.

> 
>> Thus it is a
>> regression. And as you have asserted so vehemently in the hwaccel/mt thread
>> regressions are not acceptable.
> 
> There is no easy workaround for that.
> 
> Best regards,
> Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>