[FFmpeg-devel] [PATCH v3] lavc/rawdec: Use AV_PIX_FMT_PAL8 for 1-bit raw AVI video

[Michael Niedermayer]

On Mon, Jan 25, 2016 at 01:39:13AM +0100, Mats Peterson wrote:
> On 01/25/2016 01:31 AM, Mats Peterson wrote:
> >On 01/25/2016 01:30 AM, Mats Peterson wrote:
> >
> >>Well, this one is still incorrect, since it doesn't cater for different
> >>strides.
> >>
> >>Mats
> >>
> >
> >I would like you to focus on version 5 that I've both mailed to you and
> >posted here.
> >
> >Mats
> >
> 
> And why did you omit the 8 bpp changes for AVI? That's what this
> patch (or version 5 rather) is about.

put bluntly, because iam not convinced that this is valid in AVI

IIUC you created a avi file with a palette and a blue entry and 1bpp
and then modified ffmpeg to display that with blue.
ok
but
is that correct, does microsofts player display that with blue too?
does the AVI spec say that 1bpp has a palette?
do unmodified avi files exist out in the wild that have 1bpp palettes?

if 1bpp in AVI is per spec and MS reference supposed to have a palette
then we should too and iam happy with the change otherwise we should
keep mono for avi

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160125/691e3d09/attachment.sig>