[FFmpeg-devel] [PATCHv3] avcodec: Cineform HD Decoder

[Ronald S. Bultje]

Hi,

On Mon, Jan 25, 2016 at 9:34 AM, Kieran Kunhya <kieran618 at googlemail.com>
wrote:

> On 25 Jan 2016 2:29 p.m., "Michael Niedermayer" <michael at niedermayer.cc>
> wrote:
> >
> > On Mon, Jan 25, 2016 at 12:34:03AM +0000, Kieran Kunhya wrote:
> > > Decodes YUV 4:2:2 10-bit and RGB 12-bit files.
> > > Older files with more subbands, skips, Bayer, alpha not supported.
> > > Alpha requires addition of GBRAP12 pixel format.
> > > ---
> > >  libavcodec/Makefile     |   1 +
> > >  libavcodec/allcodecs.c  |   1 +
> > >  libavcodec/avcodec.h    |   1 +
> > >  libavcodec/cfhd.c       | 744
> ++++++++++++++++++++++++++++++++++++++++++++++++
> > >  libavcodec/cfhd.h       | 107 +++++++
> > >  libavcodec/cfhddata.c   | 327 +++++++++++++++++++++
> > >  libavcodec/codec_desc.c |   7 +
> > >  libavformat/riff.c      |   1 +
> > >  8 files changed, 1189 insertions(+)
> > >  create mode 100644 libavcodec/cfhd.c
> > >  create mode 100644 libavcodec/cfhd.h
> > >  create mode 100644 libavcodec/cfhddata.c
> >
> > breaks build for arm
> >
> > libavcodec/cfhd.c: In function ‘cfhd_decode’:
> > libavcodec/cfhd.c:482:13: warning: ISO C90 forbids mixed declarations and
> code
> > In file included from ffmpeg/libavutil/intmath.h:30:0,
> >                  from ffmpeg/libavutil/common.h:103,
> >                  from libavcodec/cfhd.c:27:
> > ffmpeg/libavutil/arm/intmath.h: In function ‘filter’:
> > ffmpeg/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably
> doesn’t match constraints
> > ffmpeg/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably
> doesn’t match constraints
> > ffmpeg/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably
> doesn’t match constraints
> > ffmpeg/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably
> doesn’t match constraints
> > ffmpeg/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably
> doesn’t match constraints
> > ffmpeg/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably
> doesn’t match constraints
> > ffmpeg/libavutil/arm/intmath.h:77:5: error: impossible constraint in
> ‘asm’
> > ffmpeg/libavutil/arm/intmath.h:77:5: error: impossible constraint in
> ‘asm’
> > ffmpeg/libavutil/arm/intmath.h:77:5: error: impossible constraint in
> ‘asm’
> > ffmpeg/libavutil/arm/intmath.h:77:5: error: impossible constraint in
> ‘asm’
> > ffmpeg/libavutil/arm/intmath.h:77:5: error: impossible constraint in
> ‘asm’
> > ffmpeg/libavutil/arm/intmath.h:77:5: error: impossible constraint in
> ‘asm’
> >
> >
> > [...]
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Looks like an existing bug, no?


av_clip_uintp2 requires an integer literal instead of a variable as input.

Ronald