[FFmpeg-devel] [PATCH] Add TargetTypeValue in Matroska tag prefix

[Michael Niedermayer]

On Wed, Jan 27, 2016 at 08:00:23PM -0500, Pierre Choffet wrote:
> Previously, the Matroska tag names were structured like this:
>   [<TargetType>/]<TagName>
> This lead to an issue when <TargetType> is not available: the different levels tags overwrite each
> other when they have the same name.
> 
> This patch transforms the name prefix into:
>   <TargetTypeValue>[-<TargetType>]/<TagName>
> 
> As the TargetTypeValue has default value in case it has no data, it prevents from overriding of other levels
> tags.
> ---
>  libavformat/matroskadec.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

breaks fate
--- ./tests/ref/lavf-fate/ogg_vp3       2016-01-28 00:30:52.275988445 +0100
+++ tests/data/fate/lavf-fate-ogg_vp3   2016-01-28 14:15:45.309031128 +0100
@@ -1,3 +1,3 @@
-4bd51dac3194fa88ae33767c25b4b1e6 *./tests/data/lavf-fate/lavf.ogg
-417621 ./tests/data/lavf-fate/lavf.ogg
+3704ef62ea932fbeeac84e709384643d *./tests/data/lavf-fate/lavf.ogg
+417647 ./tests/data/lavf-fate/lavf.ogg
 ./tests/data/lavf-fate/lavf.ogg CRC=0x037e3e79
Test lavf-fate-ogg_vp3 failed. Look at tests/data/fate/lavf-fate-ogg_vp3.err for details.
make: *** [fate-lavf-fate-ogg_vp3] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160128/159372a3/attachment.sig>