[FFmpeg-devel] [FFmpeg-cvslog] build: use a link instead of changing current directory when compiling

[Michael Niedermayer]

On Wed, Jan 27, 2016 at 11:52:28PM +0100, Andreas Cadhalpun wrote:
> On 27.01.2016 12:09, Michael Niedermayer wrote:
> > On Tue, Jan 26, 2016 at 11:07:43PM +0100, Andreas Cadhalpun wrote:
> >>  configure |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 1edecc11203a53b6dfa3f9816583b7bceb6b6491  0001-configure-fall-back-to-using-full-path-if-src-is-a-d.patch
> >> From 72b2b0c9533d96b778be4c96a418b22075f1d39a Mon Sep 17 00:00:00 2001
> >> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> Date: Tue, 26 Jan 2016 22:54:01 +0100
> >> Subject: [PATCH] configure: fall back to using full path if src is a directory
> >>
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> > 
> > also this fails too:
> >  ./configure && make distclean
> > 
> > rm: cannot remove `src': Is a directory
> > make: *** [distclean] Error 1
> 
> Indeed, if it doesn't get created, it shouldn't be removed.
> Updated patch attached.
> 
> Best regards,
> Andreas

>  Makefile  |    5 ++++-
>  configure |    2 +-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 67bd05c13361082708ccc24ee5828c4c00a443a3  0001-configure-fall-back-to-using-full-path-if-src-is-a-d.patch
> From 3dcdf81a2db324316c956553340bf42ce5d51278 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Tue, 26 Jan 2016 22:54:01 +0100
> Subject: [PATCH] configure: fall back to using full path if src is a directory
> 
> And don't try to remove src on distclean in that case.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  Makefile  | 5 ++++-
>  configure | 2 +-
>  2 files changed, 5 insertions(+), 2 deletions(-)

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160128/c4a150dc/attachment.sig>