[FFmpeg-devel] [libav-devel] [PATCHv3] avcodec: Cineform HD Decoder

[Vittorio Giovara]

On Mon, Jan 25, 2016 at 6:15 PM, Kieran Kunhya <kieran618 at googlemail.com> wrote:
>>> +{
>>> +    CFHDContext *s = avctx->priv_data;
>>> +
>>> +    avctx->pix_fmt             = AV_PIX_FMT_YUV422P10;
>>
>> if the decoder supports multiple pixel formats it's better not to
>> initialize the pixel format here, and wait until decode(). Otherwise
>> it's going to cause a "parameters changed" warning and reinit any
>> previous filter chain.
>
> There are some samples which don't have a pixel format flagged and are
> implicitly AV_PIX_FMT_YUV422P10.

I still think this should be put off until you get to decoding a
frame: having a filterchain reinitialization can be disastrous under
certain conditions.

>>> +
>>> +end:
>>> +    if (ret < 0)
>>> +        return ret;
>>> +
>>> +    *got_frame = 1;
>>> +    return avpkt->size;
>>
>> avpkt->size - bytestream2_get_bytes_left(&gb) no?
>
> Guaranteed to read all tags.

if all bytes have been read return 0 then
-- 
Vittorio