[FFmpeg-devel] [PATCH] Revert "do not write f2 if not interlaced"

[Michael Niedermayer]

On Fri, Jan 29, 2016 at 12:39:03PM +0100, Sebastian Dröge wrote:
> From: Sebastian Dröge <sebastian at centricular.com>
> 
> This reverts commit 8ed82d8174a666f80ab8834e3617cbe91ae740a9.
> 
> SMPTE S377-1-2009c defines in F.4.1 that the Video Line Map should
> always be an array with two 32 bit integers as elements. This is
> repeated in G.2.12 with actual examples for progressive content,
> where the second value would always be 0.
> 
> Additionally, the IRT MXF analyser also lists this as the only
> error in the MXF output from ffmpeg: https://mxf-analyser-cloud.irt.de
> ---
>  libavformat/mxfenc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

breaks fate
(you need to update the checksums if these chnages are intended)

--- ./tests/ref/lavf/mxf_opatom 2016-01-28 17:59:39.081314141 +0100
+++ tests/data/fate/lavf-mxf_opatom     2016-01-29 13:29:04.074792325 +0100
@@ -1,3 +1,2 @@
-2205907020248f73876eaad745d2f5b5 *./tests/data/lavf/lavf.mxf_opatom
+1645bbaca32118e929a00cb1ea0590ba *./tests/data/lavf/lavf.mxf_opatom
 4717113 ./tests/data/lavf/lavf.mxf_opatom
-./tests/data/lavf/lavf.mxf_opatom CRC=0xf55aa22a
Test lavf-mxf_opatom failed. Look at tests/data/fate/lavf-mxf_opatom.err for details.
make: *** [fate-lavf-mxf_opatom] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/lavf/mxf        2016-01-28 17:59:39.081314141 +0100
+++ tests/data/fate/lavf-mxf    2016-01-29 13:29:04.586792336 +0100
@@ -1,9 +1,9 @@
-6d00bf68ec95d0aac959defccdb0190e *./tests/data/lavf/lavf.mxf
+293050235c5c852a3189a9d98c14c009 *./tests/data/lavf/lavf.mxf
 525369 ./tests/data/lavf/lavf.mxf
 ./tests/data/lavf/lavf.mxf CRC=0xdbfff6f1
-0bbdd13de78db8ab9314f083b7da0f30 *./tests/data/lavf/lavf.mxf
+4eb9eb1487526148b3a8603aa1b8cdda *./tests/data/lavf/lavf.mxf
 560697 ./tests/data/lavf/lavf.mxf
 ./tests/data/lavf/lavf.mxf CRC=0x11a6178e
-462f95f19b3e0fd119a204a96eb6f424 *./tests/data/lavf/lavf.mxf
+df3aabca4111b871b0bca5187878a775 *./tests/data/lavf/lavf.mxf
 525369 ./tests/data/lavf/lavf.mxf
 ./tests/data/lavf/lavf.mxf CRC=0xdbfff6f1
Test lavf-mxf failed. Look at tests/data/fate/lavf-mxf.err for details.
make: *** [fate-lavf-mxf] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160129/d8ee6c79/attachment.sig>