[FFmpeg-devel] [PATCH 1/2] vf_phase: Reduce the scope of several variables

Paul B Mahol onemda at gmail.com
Sat Jan 30 21:47:21 CET 2016


On 1/30/16, Timothy Gu <timothygu99 at gmail.com> wrote:
> ---
>  libavfilter/vf_phase.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/libavfilter/vf_phase.c b/libavfilter/vf_phase.c
> index 7249388..fadeb62 100644
> --- a/libavfilter/vf_phase.c
> +++ b/libavfilter/vf_phase.c
> @@ -116,14 +116,7 @@ static int config_input(AVFilterLink *inlink)
>   */
>  static enum PhaseMode analyze_plane(void *ctx, enum PhaseMode mode, AVFrame
> *old, AVFrame *new)
>  {
> -    double bdiff, tdiff, pdiff, scale;
> -    const int ns = new->linesize[0];
> -    const int os = old->linesize[0];
> -    const uint8_t *nptr = new->data[0];
> -    const uint8_t *optr = old->data[0];
> -    const int h = new->height;
> -    const int w = new->width;
> -    int bdif, tdif, pdif;
> +    double bdiff, tdiff, pdiff;
>
>      if (mode == AUTO) {
>          mode = new->interlaced_frame ? new->top_field_first ?
> @@ -136,6 +129,15 @@ static enum PhaseMode analyze_plane(void *ctx, enum
> PhaseMode mode, AVFrame *old
>      if (mode <= BOTTOM_FIRST) {
>          bdiff = pdiff = tdiff = 65536.0;
>      } else {
> +        const int ns = new->linesize[0];
> +        const int os = old->linesize[0];
> +        const uint8_t *nptr = new->data[0];
> +        const uint8_t *optr = old->data[0];
> +        const int h = new->height;
> +        const int w = new->width;
> +        int bdif, tdif, pdif;
> +        double scale;
> +
>          int top = 0, t;
>          const uint8_t *rend, *end = nptr + (h - 2) * ns;
>

ok


More information about the ffmpeg-devel mailing list