[FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

[Michael Niedermayer]

On Sun, Jan 31, 2016 at 04:03:36PM +0100, Mats Peterson wrote:
> On 01/31/2016 03:59 PM, Michael Niedermayer wrote:
> >ffmpeg source is not unchanegable,
> >if you belive that pal8 should be used in place of monochrome you
> >could certaily make the code act more reasonable with a 2 entry
> >(black+white) PAL8
> >
> 
> I don't believe. It's a fact. And it is used in other places
> (QuickTime, both raw and RLE, and BMP) for 1 bpp data, so why
> shouldn't it for AVI as well? Please, just apply my latest patch
> that restores the pal8-only behaviour. This is a lot more logical
> than switching to monow for the case of black & white, which has to
> detected with extraneous code, and which just complicates things in
> my book.

there are many options

support only black/white monochrome avis (this covers all real world
samples we have)

support only pal8 (this supports hypothetical paletted 1bpp but breaks
converting to other monochrome formats without the user manually
forcing monochrome, which he has no reason to really think that he
would need to do that)

support pal8+black/white monochrome avis, more complex code
but supports both hypothetical paletted 1bpp and has correctly
automatically working monochrome encoding support



> The customer is always right, remember?

yes but we have alot of "customers", i dont know what they prefer
i dont even have a good approximation on what they prefer.
but i suspect they probably prefer ffmpeg to "just work", most
customers tend to want things to "just work"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160131/86af0004/attachment.sig>